Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Quarter picker #22468

Merged
merged 3 commits into from Mar 21, 2020
Merged

feat: Quarter picker #22468

merged 3 commits into from Mar 21, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #22150

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English DatePicker support quarter picker.
🇨🇳 Chinese DatePicker 支持季度选择器。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/date-picker/demo/basic.md
View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 21, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1117d9a:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

@afc163 afc163 commented Mar 21, 2020

感觉 Picker 的自定义 Trigger 得搞搞,不然很难满足设计稿里的需求。

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b065230:

Sandbox Source
antd reproduction template Configuration

Copy link
Member

@shaodahong shaodahong left a comment

LGTM

afc163
afc163 approved these changes Mar 21, 2020
@zombieJ zombieJ merged commit 1e95c6c into feature Mar 21, 2020
25 of 27 checks passed
@zombieJ zombieJ deleted the quarter-picker branch Mar 21, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants