Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecesary render with gutter={[7,9]} #22474 #22475

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

dolfje
Copy link
Contributor

@dolfje dolfje commented Mar 21, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

  1. Reduce the rerenders of the row Row extra render with gutter={[7,9]} #22474

💡 Background and solution

  1. Problem is that there are multiple renders
  2. Is is because the code thinks that screens is important, while that is only the case with an object type gutter

📝 Changelog

No userside changes

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • [ not needed ] Doc is updated/provided or not needed
  • [ not needed ] Demo is updated/provided or not needed
  • [ not needed ] TypeScript definition is updated/provided or not needed
  • [ not needed ] Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 21, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ffe5620:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants