Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecesary render with gutter={[7,9]} #22474 #22475

Merged
merged 1 commit into from Mar 22, 2020

Conversation

dolfje
Copy link
Contributor

@dolfje dolfje commented Mar 21, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

  1. Reduce the rerenders of the row #22474

馃挕 Background and solution

  1. Problem is that there are multiple renders
  2. Is is because the code thinks that screens is important, while that is only the case with an object type gutter

馃摑 Changelog

No userside changes

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • [ not needed ] Doc is updated/provided or not needed
  • [ not needed ] Demo is updated/provided or not needed
  • [ not needed ] TypeScript definition is updated/provided or not needed
  • [ not needed ] Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 21, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ffe5620:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit fd0038e into ant-design:master Mar 22, 2020
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants