Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null value tooltip of Slider #22482

Merged
merged 1 commit into from Mar 22, 2020
Merged

fix: null value tooltip of Slider #22482

merged 1 commit into from Mar 22, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 22, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22480

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Slider tooltip crash when with nullable value.
🇨🇳 Chinese 修复 Slider 使用 nullable 值时弹出提示会崩溃的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 22, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af5e622:

Sandbox Source
antd reproduction template Configuration

@zombieJ zombieJ merged commit 4e270e1 into master Mar 22, 2020
27 of 29 checks passed
@zombieJ zombieJ deleted the fix-slider-tooltip branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants