Skip to content

fix: null value tooltip of Slider#22482

Merged
zombieJ merged 1 commit intomasterfrom
fix-slider-tooltip
Mar 22, 2020
Merged

fix: null value tooltip of Slider#22482
zombieJ merged 1 commit intomasterfrom
fix-slider-tooltip

Conversation

@zombieJ
Copy link
Copy Markdown
Member

@zombieJ zombieJ commented Mar 22, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22480

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Slider tooltip crash when with nullable value.
🇨🇳 Chinese 修复 Slider 使用 nullable 值时弹出提示会崩溃的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link
Copy Markdown

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Copy Markdown
Contributor

ant-design-bot commented Mar 22, 2020

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af5e622:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider with input field crashes when removing value from input field

2 participants