Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import react-slick instead of require #22507

Merged
merged 2 commits into from Mar 23, 2020
Merged

refactor: import react-slick instead of require #22507

merged 2 commits into from Mar 23, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 23, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22501

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Carousel cannot works on Snowpack.
🇨🇳 Chinese 修复 Carousel 无法使用 Snowpack 构建的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 mentioned this pull request Mar 23, 2020
10 tasks
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 23, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e6c501b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 23, 2020

Codecov Report

Merging #22507 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22507      +/-   ##
==========================================
- Coverage   98.16%   98.16%   -0.01%     
==========================================
  Files         306      306              
  Lines        7071     7070       -1     
  Branches     1943     1944       +1     
==========================================
- Hits         6941     6940       -1     
  Misses        130      130
Impacted Files Coverage Δ
components/carousel/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011cac4...e6c501b. Read the comment docs.

@afc163 afc163 merged commit e2a9ab4 into master Mar 23, 2020
29 of 30 checks passed
@afc163 afc163 deleted the fix-esm-import branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants