Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4.0 Table with emptyText is not centered #22548

Merged
merged 2 commits into from Mar 24, 2020
Merged

fix: 4.0 Table with emptyText is not centered #22548

merged 2 commits into from Mar 24, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Mar 24, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

https://codesandbox.io/s/antd-reproduction-template-zd736

close #22176

💡 Background and solution

ref #22176

📝 Changelog

Language Changelog
🇺🇸 English - Fix Table emptyText is not centered.
- Table with empty data should not show pagination.
🇨🇳 Chinese - 修复 Table 空文本没有居中的问题。
- 修复 Table 空数据依然展示了分页的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 24, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7989f40:

Sandbox Source
antd reproduction template Configuration
antd reproduction template PR

@afc163
Copy link
Member

@afc163 afc163 commented Mar 24, 2020

CI failed

@hengkx
Copy link
Member Author

@hengkx hengkx commented Mar 24, 2020

image
为什么没有修改过的文件本地测试通不过?

@afc163
Copy link
Member

@afc163 afc163 commented Mar 24, 2020

Reinstall node_modules.

@afc163
Copy link
Member

@afc163 afc163 commented Mar 24, 2020

image

@afc163
Copy link
Member

@afc163 afc163 commented Mar 24, 2020

changelog 也加一下空数据下不展示分页的部分。

@hengkx hengkx changed the title fix : 4.0 Table with emptyText is not centered fix: 4.0 Table with emptyText is not centered Mar 24, 2020
@hengkx
Copy link
Member Author

@hengkx hengkx commented Mar 24, 2020

image
还有一个ci错误 是生成的文件太大了

@afc163
Copy link
Member

@afc163 afc163 commented Mar 24, 2020

@hengkx 这个是我们底层工具和依赖的问题,暂时忽略。

@afc163 afc163 merged commit c7add36 into ant-design:master Mar 24, 2020
17 of 18 checks passed
@hengkx hengkx deleted the fix-22176 branch Mar 24, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
@mrcljx mrcljx mentioned this pull request Aug 4, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants