Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Warning with defaultValue #22571

Merged
merged 2 commits into from Mar 24, 2020
Merged

chore: Warning with defaultValue #22571

merged 2 commits into from Mar 24, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 24, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22570

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Warning Form.Item with defaultValue when it's controlled.
🇨🇳 Chinese 添加 Form.Item 在受控时使用 defaultValue 的警告信息。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 24, 2020

@zombieJ zombieJ merged commit d0e182e into master Mar 24, 2020
27 of 29 checks passed
@zombieJ zombieJ deleted the warning branch Mar 24, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8f3615:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 24, 2020

Codecov Report

Merging #22571 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22571      +/-   ##
==========================================
+ Coverage   98.16%   98.16%   +<.01%     
==========================================
  Files         306      306              
  Lines        7071     7072       +1     
  Branches     1944     1944              
==========================================
+ Hits         6941     6942       +1     
  Misses        130      130
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a342f...e8f3615. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants