Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix Alert cannot work with Tooltip #22594

Merged
merged 1 commit into from Mar 25, 2020
Merged

fix: 🐛 Fix Alert cannot work with Tooltip #22594

merged 1 commit into from Mar 25, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 25, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22579

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Alert cannot work with Tooltip/Popover.
🇨🇳 Chinese 修复 Alert 无法和 Tooltip/Popover 一起使用的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@codecov
Copy link

@codecov codecov bot commented Mar 25, 2020

Codecov Report

Merging #22594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22594   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         306      306           
  Lines        7078     7078           
  Branches     1900     1900           
=======================================
  Hits         6947     6947           
  Misses        131      131
Impacted Files Coverage Δ
components/alert/index.tsx 95.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee78492...c6d88e5. Read the comment docs.

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 25, 2020

@afc163 afc163 merged commit b4da5cb into master Mar 25, 2020
28 of 29 checks passed
@afc163 afc163 deleted the fix-alert branch Mar 25, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants