Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: optimize form rtl and demo #22621

Merged
merged 1 commit into from Mar 30, 2020
Merged

style: optimize form rtl and demo #22621

merged 1 commit into from Mar 30, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Mar 26, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

  • 1 label 在 RTL 下显示异常

WeChat328da3761342aa812008965996457a33

  • 2有几个 Demo 的例子在 RTL 下异常

📝 Changelog

Language Changelog
🇺🇸 English Fix label display in Form RTL; optimize Form RTL Demo
🇨🇳 Chinese 修复 Form RTL 下 label 显示;优化 Form RTL Demo

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/advanced-search.md
View rendered components/form/demo/complex-form-control.md
View rendered components/form/demo/customized-form-controls.md
View rendered components/form/demo/dynamic-form-item.md
View rendered components/form/demo/form-context.md
View rendered components/form/demo/normal-login.md
View rendered components/form/demo/validate-static.md

@xrkffgg xrkffgg requested a review from afc163 Mar 26, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 26, 2020

@codecov
Copy link

@codecov codecov bot commented Mar 26, 2020

Codecov Report

Merging #22621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22621   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         306      306           
  Lines        7078     7078           
  Branches     1945     1945           
=======================================
  Hits         6947     6947           
  Misses        131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f0308...603501c. Read the comment docs.

@xrkffgg xrkffgg requested a review from zombieJ Mar 27, 2020
@@ -32,6 +32,11 @@
margin-left: 4px;
}
}
&::after {
.@{form-prefix-cls}-rtl & {
margin: 0 @form-item-label-colon-margin-left 0 @form-item-label-colon-margin-right;
Copy link
Contributor

@abdih abdih Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the specifications for margin's shorthand property, I believe @form-item-label-colon-margin-left and @form-item-label-colon-margin-right should be interchanged.

@afc163 afc163 merged commit fd7e7d3 into master Mar 30, 2020
29 of 30 checks passed
@afc163 afc163 deleted the opt-form-rtl branch Mar 30, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants