Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust ts define #22662

Merged
merged 2 commits into from Mar 27, 2020
Merged

chore: adjust ts define #22662

merged 2 commits into from Mar 27, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 27, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

https://ant.design/components/form-cn/#components-form-demo-dynamic-form-item

image

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item children ts define.
🇨🇳 Chinese 修复 Form.Item children 的类型定义。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 27, 2020

@@ -19,7 +19,7 @@ export type ValidateStatus = typeof ValidateStatuses[number];

type RenderChildren = (form: FormInstance) => React.ReactNode;
type RcFieldProps = Omit<FieldProps, 'children'>;
type ChildrenType = React.ReactElement | RenderChildren | React.ReactElement[] | null;
type ChildrenType = RenderChildren | React.ReactNode | null;
Copy link
Member

@afc163 afc163 Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要 null 了

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94cfa71:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2112578:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 27, 2020

Codecov Report

Merging #22662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22662   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         306      306           
  Lines        7078     7078           
  Branches     1945     1945           
=======================================
  Hits         6947     6947           
  Misses        131      131
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43de6f3...2112578. Read the comment docs.

@zombieJ zombieJ merged commit 567e8a1 into master Mar 27, 2020
30 of 31 checks passed
@zombieJ zombieJ deleted the adjust-item-ts branch Mar 27, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants