Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Card Tabs do not support small size #22666

Merged
merged 5 commits into from Apr 1, 2020

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Mar 27, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #22637

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English fix Tabs do not support small size
馃嚚馃嚦 Chinese 淇 Tabs 涓嶆敮鎸佸皬灏哄

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 27, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4bb1248:

Sandbox Source
antd reproduction template Configuration
澶у皬 - Ant Design Demo Issue #22637

@codecov
Copy link

@codecov codecov bot commented Mar 28, 2020

Codecov Report

Merging #22666 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22666      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%     
==========================================
  Files         360      360              
  Lines        7213     7211       -2     
  Branches     1981     1981              
==========================================
- Hits         7089     7087       -2     
  Misses        124      124              
Impacted Files Coverage 螖
components/tabs/index.tsx 96.77% <酶> (-0.11%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dc4d98a...4bb1248. Read the comment docs.

@MrHeer MrHeer requested a review from zombieJ Mar 28, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 28, 2020

Use same padding as normal mode: https://codesandbox.io/s/antd-reproduction-template-oysr5

鎴睆2020-03-28 涓婂崍10 43 08

鎴睆2020-03-28 涓婂崍10 43 14

components/style/themes/default.less Outdated Show resolved Hide resolved
@afc163
Copy link
Member

@afc163 afc163 commented Mar 28, 2020

@MrHeer
Copy link
Contributor Author

@MrHeer MrHeer commented Mar 29, 2020

Use same padding as normal mode: codesandbox.io/s/antd-reproduction-template-oysr5

鎴睆2020-03-28 涓婂崍10 43 08 鎴睆2020-03-28 涓婂崍10 43 14

@zombieJ 鎴戜笉澶槑鐧戒綘鐨勬剰鎬濓紝鑳藉璇存槑涓涓嬪悧锛

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 29, 2020

鍜岄潪鏍囩鍗$墖涓鏍凤紝鐢 padding 鏉ユ帶鍒朵竴涓 small size 鐨勯珮搴︺

@MrHeer
Copy link
Contributor Author

@MrHeer MrHeer commented Mar 29, 2020

@zombieJ 鎴戜慨鏀逛簡涓涓嬶紝璇风湅涓涓嬫槸涓嶆槸杩欐牱鐨

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 29, 2020

@MrHeer MrHeer force-pushed the fix-Card-Tabs-size branch 2 times, most recently from 9eec17d to eb636e2 Compare Mar 30, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Mar 30, 2020

@MrHeer
Copy link
Contributor Author

@MrHeer MrHeer commented Mar 30, 2020

杩欓噷鎼炰釜 demo 鍑烘潵銆

https://preview-22666-ant-design.surge.sh/components/tabs-cn/#components-tabs-demo-size

浣犵殑鎰忔濇槸鎶婅繖涓狣emo涓殑鏅歍abs淇敼涓哄崱鐗囩被鍨嬬殑鍚楋紵

@afc163
Copy link
Member

@afc163 afc163 commented Mar 30, 2020

鍔犱竴涓崱鐗 Tabs锛屽ソ棰勮銆

@MrHeer
Copy link
Contributor Author

@MrHeer MrHeer commented Mar 30, 2020

濂界殑

@afc163
Copy link
Member

@afc163 afc163 commented Mar 30, 2020

ci 鎸備簡

@afc163
Copy link
Member

@afc163 afc163 commented Mar 30, 2020

image

涓嶅お缇庤锛屽姞涓棿璺濄

@MrHeer
Copy link
Contributor Author

@MrHeer MrHeer commented Apr 1, 2020

杩樻湁浠涔堥棶棰樺悧锛

@afc163 afc163 merged commit 3450a82 into ant-design:master Apr 1, 2020
20 checks passed
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants