Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔢 improve default pagination switch experience #22711

Merged
merged 5 commits into from Mar 29, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 29, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18201

💡 Background and solution

  • 当 total 大于 50 时,默认显示切换页数选择器。优化大数据下的默认分页体验。
  • 页数选择器的默认选项从 10,20,30,40 修改为 10,20,50,100。
    image
  • 优化 10 页以内的分页器宽度,使其更统一,解决 #18201 的问题。
调整前 调整后 ✅
截屏2020-03-29下午5 14 20 截屏2020-03-29下午5 13 37

📝 Changelog

Language Changelog
🇺🇸 English - Pagination will show size changer when total>50.
- Unify Pagination items to fixed length.
- change default size options to 10, 20, 50, 100.
🇨🇳 Chinese - Pagination 当 total>50 时默认显示切换页数选择器。
- 统一 Pagination 十页以内的页码个数使其宽度更统一。
- Pagination 调整默认页数选项为 10, 20, 50, 100。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 requested a review from zombieJ as a code owner Mar 29, 2020
@afc163 afc163 changed the title feat: 🔢 improve default pagination switch expierence feat: 🔢 improve default pagination switch experience Mar 29, 2020
@afc163 afc163 changed the base branch from master to feature Mar 29, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 29, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 643cf1e:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 29, 2020

用例挂了

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 29, 2020

\rebase

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 29, 2020

/rebase

@codecov
Copy link

@codecov codecov bot commented Mar 29, 2020

Codecov Report

Merging #22711 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22711   +/-   ##
========================================
  Coverage    98.07%   98.07%           
========================================
  Files          360      360           
  Lines         7227     7227           
  Branches      1985     1986    +1     
========================================
  Hits          7088     7088           
  Misses         139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973c649...643cf1e. Read the comment docs.

@afc163 afc163 changed the title feat: 🔢 improve default pagination switch experience [WIP] feat: 🔢 improve default pagination switch experience Mar 29, 2020
@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 29, 2020

再调整一些细节ing

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 29, 2020

👌 那我再等等

@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 29, 2020

可以并行起来,估计我六点前能搞完。

@afc163 afc163 changed the title [WIP] feat: 🔢 improve default pagination switch experience feat: 🔢 improve default pagination switch experience Mar 29, 2020
@afc163
Copy link
Member Author

@afc163 afc163 commented Mar 29, 2020

done

@zombieJ zombieJ merged commit db3a81a into feature Mar 29, 2020
30 checks passed
@zombieJ zombieJ deleted the up-pagination branch Mar 29, 2020
@zombieJ zombieJ mentioned this pull request Mar 29, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants