Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table loading compatibility #22739

merged 2 commits into from Mar 30, 2020

fix: Table loading compatibility #22739

merged 2 commits into from Mar 30, 2020


Copy link

@afc163 afc163 commented Mar 30, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #22733

馃挕 Background and solution

<Table loading={{ tip: 'tip' }} />

should be loading.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

bottomPaginationNode = renderPagination();
Copy link
Member Author

@afc163 afc163 Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

@ant-design-bot ant-design-bot commented Mar 30, 2020

Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5329074:

Sandbox Source
antd reproduction template Configuration

Copy link

@codecov codecov bot commented Mar 30, 2020

Codecov Report

Merging #22739 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22739      +/-   ##
+ Coverage   98.13%   98.28%   +0.15%     
  Files         360      360              
  Lines        7221     7213       -8     
  Branches     1937     1934       -3     
+ Hits         7086     7089       +3     
+ Misses        135      124      -11
Impacted Files Coverage 螖
components/table/Table.tsx 99.2% <100%> (+8.16%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 24ae9eb...5329074. Read the comment docs.

@afc163 afc163 merged commit faa71fd into master Mar 30, 2020
32 checks passed
@afc163 afc163 deleted the fix-table-loading branch Mar 30, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants