Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Space item duplicate key #22745

Merged
merged 1 commit into from Mar 30, 2020
Merged

fix: Space item duplicate key #22745

merged 1 commit into from Mar 30, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Mar 30, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Resolve #22738

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Space item duplicate key
🇨🇳 Chinese 修复 Space 子项重复的 key

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be6de60:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 30, 2020

Codecov Report

Merging #22745 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22745   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         360      360           
  Lines        7213     7213           
  Branches     1982     1982           
=======================================
  Hits         7089     7089           
  Misses        124      124
Impacted Files Coverage Δ
components/space/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4668f3...be6de60. Read the comment docs.

@afc163 afc163 requested a review from ant-design-bot Mar 30, 2020
@afc163 afc163 merged commit 0f2f270 into ant-design:master Mar 30, 2020
21 checks passed
@paul-vd
Copy link

@paul-vd paul-vd commented Apr 1, 2020

Any eta on this?

@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
@shaodahong shaodahong deleted the fix-space-duplicate-key branch Apr 3, 2020
@hetaoov
Copy link

@hetaoov hetaoov commented Apr 11, 2020

大佬。这个我应该怎么弄呢?是更新antd 版本吗?还是自己改源码

@shaodahong
Copy link
Member Author

@shaodahong shaodahong commented Apr 11, 2020

大佬。这个我应该怎么弄呢?是更新antd 版本吗?还是自己改源码

@hetaoov 更新到最新版本(4.1.2)即可

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants