Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --scroll-bar var default value #22754

Merged
merged 3 commits into from Mar 30, 2020
Merged

Conversation

MYKEU
Copy link
Contributor

@MYKEU MYKEU commented Mar 30, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

--scroll-bar is not initially defined, thus, receiving the following when compiling:

 variable --scroll-bar is undefined and used without a fallback

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix variable --scroll-bar is undefined
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@MYKEU MYKEU changed the title Fix --scroll-bar var default value fix: --scroll-bar var default value Mar 30, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 021618c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 30, 2020

Codecov Report

Merging #22754 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22754   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         360      360           
  Lines        7213     7213           
  Branches     1934     1971   +37     
=======================================
  Hits         7089     7089           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 40eae38...021618c. Read the comment docs.

Co-Authored-By: 鍋忓彸 <afc163@gmail.com>
@afc163 afc163 merged commit cd0203d into ant-design:master Mar 30, 2020
17 of 18 checks passed
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants