Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix date_picker et time_picker locale for πŸ‡«πŸ‡· #22769

Conversation

PaulJln
Copy link
Contributor

@PaulJln PaulJln commented Mar 30, 2020

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ”— Related issue link

close #22674

Open antd/lib/date-picker/locale/fr_FR.d.ts and antd/lib/date-picker/locale/en_US.d.ts, type lang looks different. The type rangePlaceholder: string[] is missing.

Additional attribute placeholderQuarter: [] was missing as well.

πŸ’‘ Background and solution

Adding fields in target files.

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English πŸ‡«πŸ‡· Date picker and time picker update
πŸ‡¨πŸ‡³ Chinese πŸ‡«πŸ‡· ζ—₯ζœŸι€‰ζ‹©ε™¨ε’Œζ—Άι—΄ι€‰ζ‹©ε™¨ζ›΄ζ–°

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@PaulJln PaulJln changed the title Fix date_picker et time_picker locale Fix date_picker et time_picker locale for πŸ‡«πŸ‡· Mar 30, 2020
@PaulJln PaulJln changed the title Fix date_picker et time_picker locale for πŸ‡«πŸ‡· Fix date_picker et time_picker locale for πŸ‡«πŸ‡· Mar 30, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 30, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 86de666:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 30, 2020

Codecov Report

Merging #22769 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22769   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         361      361           
  Lines        7212     7212           
  Branches     1971     1981   +10     
=======================================
  Hits         7088     7088           
  Misses        124      124
Impacted Files Coverage Ξ”
components/date-picker/locale/fr_FR.tsx 100% <ΓΈ> (ΓΈ) ⬆️
components/time-picker/locale/fr_FR.tsx 100% <ΓΈ> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update cefb7b2...86de666. Read the comment docs.

@yoyo837 yoyo837 changed the title Fix date_picker et time_picker locale for πŸ‡«πŸ‡· fix: Fix date_picker et time_picker locale for πŸ‡«πŸ‡· Mar 30, 2020
@afc163 afc163 merged commit 33e5ef2 into ant-design:master Apr 1, 2020
21 checks passed
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants