Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix order of operations for tooltipPlacement #22772

Merged
merged 1 commit into from Mar 31, 2020

Conversation

phoenixeliot
Copy link
Contributor

@phoenixeliot phoenixeliot commented Mar 31, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

No issue was created.

馃挕 Background and solution

tooltipPlacement was broken by a6c207d.
The grouping of this term was getting parsed as (tooltipPlacement || vertical) ? 'right' : 'top', which was incorrect.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Slider.tooltipPlacement option API is changed to be correct again
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

tooltipPlacement was broken by ant-design@a6c207d.
The grouping of this term was getting parsed as `(tooltipPlacement || vertical) ? 'right' : 'top'`, which was incorrect.
@phoenixeliot
Copy link
Contributor Author

@phoenixeliot phoenixeliot commented Mar 31, 2020

One test fails, but I believe it was failing before my change.

@yoyo837 yoyo837 changed the title Fix order of operations for tooltipPlacement fix: Fix order of operations for tooltipPlacement Mar 31, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Mar 31, 2020

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Mar 31, 2020

@wendellhu95

hullis
hullis approved these changes Mar 31, 2020
Copy link
Contributor

@hullis hullis left a comment

Good catch!

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Mar 31, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a392930:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Mar 31, 2020

Codecov Report

Merging #22772 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22772   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         361      361           
  Lines        7212     7212           
  Branches     1971     1934   -37     
=======================================
  Hits         7088     7088           
  Misses        124      124           
Impacted Files Coverage 螖
components/slider/index.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cefb7b2...a392930. Read the comment docs.

@yoyo837 yoyo837 merged commit ebdf911 into ant-design:master Mar 31, 2020
20 checks passed
MrHeer
MrHeer approved these changes Mar 31, 2020
@phoenixeliot phoenixeliot deleted the patch-1 branch Mar 31, 2020
@phoenixeliot
Copy link
Contributor Author

@phoenixeliot phoenixeliot commented Mar 31, 2020

Wow, nice turnaround time.

This could probably use a regression test, but I wasn't familiar enough with the testing library to want to figure it out for this. Up to y'all whether to add one.

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 1, 2020

@wendellhu95 Could you add a test case about tooltipPlacement?

@hullis
Copy link
Contributor

@hullis hullis commented Apr 1, 2020

@wendellhu95 Could you add a test case about tooltipPlacement?

OK. I will do that.

@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants