Skip to content

fix: 🐛 Affix react warning - #22790

Merged
afc163 merged 1 commit into
masterfrom
fix-affix-warning
Mar 31, 2020
Merged

fix: 🐛 Affix react warning#22790
afc163 merged 1 commit into
masterfrom
fix-affix-warning

Conversation

@afc163

@afc163 afc163 commented Mar 31, 2020

Copy link
Copy Markdown
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22683

💡 Background and solution

image

Chrome Responsive View Port Mode Only.

📝 Changelog

Language Changelog
🇺🇸 English Fix Affix throws React warning of state update on unmounted component.
🇨🇳 Chinese 修复 Affix 抛出 React state update on unmounted component 警告的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/affix/demo/basic.md

@afc163
afc163 force-pushed the fix-affix-warning branch from 1884725 to 3d1402a Compare March 31, 2020 11:39
@ant-design-bot

ant-design-bot commented Mar 31, 2020

Copy link
Copy Markdown
Contributor

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1884725f8ccebad0ed65623b27dbfcb51e0bc553:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d1402a:

Sandbox Source
antd reproduction template Configuration

@codecov

codecov Bot commented Mar 31, 2020

Copy link
Copy Markdown

Codecov Report

Merging #22790 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22790      +/-   ##
==========================================
+ Coverage   98.28%   98.28%   +<.01%     
==========================================
  Files         361      361              
  Lines        7212     7213       +1     
  Branches     1971     1971              
==========================================
+ Hits         7088     7089       +1     
  Misses        124      124
Impacted Files Coverage Δ
components/affix/index.tsx 99.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c943a...3d1402a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Antd Affix: Memory leak error

2 participants