Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove useless form textarea height #22793

Merged
merged 1 commit into from Mar 31, 2020
Merged

fix: Remove useless form textarea height #22793

merged 1 commit into from Mar 31, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 31, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22785

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Textarea with clearIcon additional margin in Form.Item.
🇨🇳 Chinese 修复 Textarea 配置 clearIcon 在 Form.Item 下会有额外的 margin 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 31, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9097381:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #22793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22793   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         361      361           
  Lines        7212     7212           
  Branches     1971     1971           
=======================================
  Hits         7088     7088           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c943a...9097381. Read the comment docs.

@zombieJ zombieJ merged commit 8f34161 into master Mar 31, 2020
32 checks passed
@zombieJ zombieJ deleted the rm-4 branch Mar 31, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants