Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rtl space #22809

Merged
merged 7 commits into from Apr 1, 2020
Merged

fix: add rtl space #22809

merged 7 commits into from Apr 1, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 1, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

none

💡 Background and solution

  • RTL 模式下,Space 的 margin 未处理

📝 Changelog

Language Changelog
🇺🇸 English Handle Space RTL style
🇨🇳 Chinese 处理 Space RTL 样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/space/demo/vertical.md
View rendered components/space/index.en-US.md
View rendered components/space/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 1, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3a2d0e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #22809 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22809      +/-   ##
==========================================
+ Coverage   98.28%   98.28%   +<.01%     
==========================================
  Files         361      361              
  Lines        7211     7212       +1     
  Branches     1933     1971      +38     
==========================================
+ Hits         7087     7088       +1     
  Misses        124      124
Impacted Files Coverage Δ
components/space/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef3215...c3a2d0e. Read the comment docs.

| Property | Description | Type | Default | Version |
| -------- | --------------- | ------------------------------------------ | ------------ | ------- |
| size | space size | `small` \| `middle` \| `large` \| `number` | `small` | 4.1.0 |
| layout | space direction | `vertical` \| `horizontal` | `horizontal` | 4.1.0 |
Copy link
Member

@afc163 afc163 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 break change,不能改。

Copy link
Member Author

@xrkffgg xrkffgg Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不换字段的话,ConfigConsumerProps 中的 direction 用不了

Copy link
Member Author

@xrkffgg xrkffgg Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等下,我再试一下

Copy link
Member

@afc163 afc163 Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

传递下来,到 Space 里改个名。

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 1, 2020

这次应该是可以了

test 文件 真是醉了,我把原有的复制回去,一提交又给我格式化了

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 1, 2020

等下,Demo 中是放到 row 中的,所以加上了 direction: rtl
单独使用的话,我还需要再加一下

@afc163
Copy link
Member

afc163 commented Apr 1, 2020

这个好了么

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 1, 2020

好了

@afc163 afc163 merged commit a91506c into master Apr 1, 2020
31 checks passed
@afc163 afc163 deleted the add-rtl-space branch Apr 1, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants