-
-
Notifications
You must be signed in to change notification settings - Fork 48.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add rtl space #22809
fix: add rtl space #22809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3a2d0e:
|
Codecov Report
@@ Coverage Diff @@
## master #22809 +/- ##
==========================================
+ Coverage 98.28% 98.28% +<.01%
==========================================
Files 361 361
Lines 7211 7212 +1
Branches 1933 1971 +38
==========================================
+ Hits 7087 7088 +1
Misses 124 124
Continue to review full report at Codecov.
|
components/space/index.en-US.md
Outdated
| Property | Description | Type | Default | Version | | ||
| -------- | --------------- | ------------------------------------------ | ------------ | ------- | | ||
| size | space size | `small` \| `middle` \| `large` \| `number` | `small` | 4.1.0 | | ||
| layout | space direction | `vertical` \| `horizontal` | `horizontal` | 4.1.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是 break change,不能改。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不换字段的话,ConfigConsumerProps 中的 direction 用不了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
等下,我再试一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
传递下来,到 Space 里改个名。
这次应该是可以了 test 文件 真是醉了,我把原有的复制回去,一提交又给我格式化了 |
等下,Demo 中是放到 row 中的,所以加上了 |
这个好了么 |
好了 |
🤔 This is a ...
🔗 Related issue link
none
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge
View rendered components/space/demo/vertical.md
View rendered components/space/index.en-US.md
View rendered components/space/index.zh-CN.md