Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Table filter onChange trigger bug #22829

Merged
merged 2 commits into from Apr 1, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 1, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22819

💡 Background and solution

补充了 FAQ 文档解决 #22819 的疑惑,修复 #22819 (comment) 这里做的例子的一个问题。

📝 Changelog

Language Changelog
🇺🇸 English Fix Table filter unexpectedly trigger onChange when no changes.
🇨🇳 Chinese 修复 Table 筛选项没有变化时触发 onChange 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 1, 2020

@afc163 afc163 changed the title fix: Table filter logic fix: 🐛 Table filter onChange trigger bug Apr 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6d30b25:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #22829 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22829      +/-   ##
==========================================
+ Coverage    98.3%   98.31%   +0.01%     
==========================================
  Files         361      361              
  Lines        7236     7238       +2     
  Branches     1939     1940       +1     
==========================================
+ Hits         7113     7116       +3     
+ Misses        123      122       -1
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 96.05% <100%> (+0.1%) ⬆️
components/_util/wave.tsx 96.15% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca2656...6d30b25. Read the comment docs.

@afc163 afc163 merged commit c38324e into master Apr 1, 2020
32 checks passed
@afc163 afc163 deleted the docs-table-faq branch Apr 1, 2020
@afc163 afc163 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants