Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table expanded logic #22832

Merged
merged 3 commits into from
Apr 1, 2020
Merged

fix: Table expanded logic #22832

merged 3 commits into from
Apr 1, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 1, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22557

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1.Adjust Table expanded row not fix width when scroll only.
🇨🇳 Chinese 1.调整 Table 在无固定列滚动时,展开行将跟随表格一同滚动;2.修复当columnchildrenundefined时整列未显示的问题;

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 1, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ac2c53:

Sandbox Source
antd reproduction template Configuration
Nested tables - Ant Design Demo Issue #22557
Nested tables - Ant Design Demo Issue #22557

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #22832 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22832   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         361      361           
  Lines        7238     7238           
  Branches     1940     1988   +48     
=======================================
  Hits         7116     7116           
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38324e...2ac2c53. Read the comment docs.

@zombieJ zombieJ merged commit f2a3ef5 into master Apr 1, 2020
@zombieJ zombieJ deleted the table branch April 1, 2020 12:57
@afc163
Copy link
Member

afc163 commented Apr 1, 2020

react-component/table#448 的 changelog 也补一下。

@afc163 afc163 mentioned this pull request Apr 1, 2020
14 tasks
afc163 referenced this pull request in react-component/table Apr 1, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Table> scroll option can't affect to expandedRender.
3 participants