Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support undefined remove filter icon #22833

Merged
merged 1 commit into from Apr 1, 2020
Merged

fix: support undefined remove filter icon #22833

merged 1 commit into from Apr 1, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 1, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22816

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table still show filter icon when filters is undefined.
🇨🇳 Chinese 修复 Table 在 filtersundefined 时仍然展示过滤按钮的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 1, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7cbbac2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 1, 2020

Codecov Report

Merging #22833 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22833   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         361      361           
  Lines        7238     7238           
  Branches     1987     1988    +1     
=======================================
  Hits         7116     7116           
  Misses        122      122
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8dbc5...7cbbac2. Read the comment docs.

@zombieJ zombieJ merged commit 9aa61b7 into master Apr 1, 2020
32 checks passed
@zombieJ zombieJ deleted the table-icon branch Apr 1, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants