Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add rtl base #22857

Merged
merged 2 commits into from Apr 9, 2020
Merged

style: add rtl base #22857

merged 2 commits into from Apr 9, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 2, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22840

💡 Background and solution

  • 一些组件的 RTL 因为放在 Row 中,而缺失基本设置
  • The RTL of some components are missing in the basic settings because they are placed in Row

📝 Changelog

Language Changelog
🇺🇸 English none
🇨🇳 Chinese none

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg requested a review from afc163 April 2, 2020 09:45
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 2, 2020

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 2, 2020

test 我明天处理下

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c8fa8f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #22857 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22857   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         364      364           
  Lines        7260     7260           
  Branches     1981     1981           
=======================================
  Hits         7138     7138           
  Misses        122      122           
Impacted Files Coverage Δ
components/checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
components/mentions/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbaf66...5c8fa8f. Read the comment docs.

@xrkffgg xrkffgg requested a review from saeedrahimi April 7, 2020 01:37
@afc163 afc163 merged commit e652eef into master Apr 9, 2020
@afc163 afc163 deleted the fix-rtl-base branch April 9, 2020 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants