Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input affix prevent dropdown focus #22887

Merged
merged 2 commits into from Apr 3, 2020
Merged

fix: Input affix prevent dropdown focus #22887

merged 2 commits into from Apr 3, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22881

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input affix with popup element can not get click focus.
🇨🇳 Chinese 修复 Input 前后缀添加弹出元素不能点击获得焦点的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 3, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d08cd65:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #22887 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22887      +/-   ##
==========================================
+ Coverage   98.31%   98.31%   +<.01%     
==========================================
  Files         363      363              
  Lines        7244     7249       +5     
  Branches     1987     1988       +1     
==========================================
+ Hits         7122     7127       +5     
  Misses        122      122
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b369717...d08cd65. Read the comment docs.

@zombieJ zombieJ merged commit 89abaca into master Apr 3, 2020
31 of 32 checks passed
@zombieJ zombieJ deleted the input-focus branch Apr 3, 2020
@ycjcl868 ycjcl868 mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants