Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 🐛 Fix multiple Select large size #22904

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22900

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select inconsistent height when mode="multiple" and size="large" />.
🇨🇳 Chinese 修复大号多选 Select 未选择时的高度问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 3, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8cab300:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 merged commit b317b7c into master Apr 3, 2020
@afc163 afc163 deleted the fix-select-height branch April 3, 2020 15:11
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #22904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22904   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         363      363           
  Lines        7250     7250           
  Branches     1988     1941   -47     
=======================================
  Hits         7128     7128           
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45d4bb...8cab300. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select with mode=multiple and size=large has incorrect height when no children are present
2 participants