Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix menu and spin style in compact mode #22908

Merged
merged 2 commits into from Apr 5, 2020
Merged

fix: fix menu and spin style in compact mode #22908

merged 2 commits into from Apr 5, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Apr 3, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

https://ant.design/components/menu-cn/#components-menu-demo-theme

https://ant.design/components/spin-cn/#components-spin-demo-size

#22815

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Menu and Spin style in compact mode
🇨🇳 Chinese 修复 Menu 和 Spin 在紧凑模式下样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/spin/demo/size.md

@AshoneA AshoneA requested review from afc163 and xrkffgg Apr 3, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 3, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd596d7:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 3, 2020

Codecov Report

Merging #22908 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22908   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         363      363           
  Lines        7250     7250           
  Branches     1941     1978   +37     
=======================================
  Hits         7128     7128           
  Misses        122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e852433...dd596d7. Read the comment docs.

components/spin/demo/size.md Outdated Show resolved Hide resolved
xrkffgg
xrkffgg approved these changes Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants