Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl(radio): fix radio rtl overrided by theme #22926

Merged
merged 1 commit into from
Apr 4, 2020
Merged

rtl(radio): fix radio rtl overrided by theme #22926

merged 1 commit into from
Apr 4, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Apr 4, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

#22815 (comment)

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@AshoneA AshoneA requested a review from xrkffgg April 4, 2020 13:14
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 4, 2020 •
edited
Loading

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 009c677635a3e2e664054ae75154817fc0ba1e4a:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a1297c:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 4, 2020 •
edited
Loading

Codecov Report

Merging #22926 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22926   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         363      363           
  Lines        7250     7250           
  Branches     1941     1941           
=======================================
  Hits         7128     7128           
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e852433...1a1297c. Read the comment docs.

xrkffgg
xrkffgg approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@xrkffgg xrkffgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个思路不错，用两个 class 来规避 单个class 的默认样式，给你点赞 👍

@afc163 afc163 merged commit 4e20ed2 into master Apr 4, 2020
@afc163 afc163 deleted the fix/radio-rtl-css branch April 4, 2020 14:27
@ycjcl868 ycjcl868 mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrkffgg xrkffgg xrkffgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AshoneA @ant-design-bot @xrkffgg @afc163