feat(theme): extract theme-js file for supprt mixin theme #22934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
Could you please add tests to make sure this change works as expected?
|
|
|
自己本地 build 试了一下，umi 那边也不用改动其他东西。 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b44fd78:
|
Codecov Report
@@ Coverage Diff @@
## master #22934 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 363 363
Lines 7250 7250
Branches 1941 1978 +37
=======================================
Hits 7128 7128
Misses 122 122 Continue to review full report at Codecov.
|
|
|
|
@afc163 umi 那边之前好像加了个 schema 阻止了配置。 |
|
|
14 tasks
14 tasks
|
我怎么感觉这个改了之后子菜单展现的时候 有明显的延迟 你们感觉到了吗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#22815
umijs/umi#4315
Extract dark-theme.js and compact-theme.js file, every theme.js file only includes their less-var, also extract default-them.js.