Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): extract theme-js file for supprt mixin theme #22934

Merged
merged 1 commit into from Apr 5, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Apr 5, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#22815

umijs/umi#4315

💡 Background and solution

Extract dark-theme.js and compact-theme.js file, every theme.js file only includes their less-var, also extract default-them.js.

📝 Changelog

Language Changelog
🇺🇸 English extract theme-js file for supprt mixin theme
🇨🇳 Chinese 抽取主题模式文件为了支持混合主题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 5, 2020

@AshoneA
Copy link
Contributor Author

@AshoneA AshoneA commented Apr 5, 2020

自己本地 build 试了一下,umi 那边也不用改动其他东西。

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b44fd78:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 5, 2020

Codecov Report

Merging #22934 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22934   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         363      363           
  Lines        7250     7250           
  Branches     1941     1978   +37     
=======================================
  Hits         7128     7128           
  Misses        122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e852433...b44fd78. Read the comment docs.

@afc163 afc163 merged commit a100139 into master Apr 5, 2020
31 of 32 checks passed
@afc163 afc163 deleted the feat/multiple-theme branch Apr 5, 2020
@zcSkr
Copy link

@zcSkr zcSkr commented Apr 10, 2020

image
image
我的还是报错,不能同时开启暗黑和紧凑

@AshoneA
Copy link
Contributor Author

@AshoneA AshoneA commented Apr 10, 2020

@afc163 umi 那边之前好像加了个 schema 阻止了配置。

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 10, 2020

是这个 umijs/plugins#131

@AshoneA
Copy link
Contributor Author

@AshoneA AshoneA commented Apr 10, 2020

是这个 umijs/plugins#131

👌,我提个 Pr

@cszo
Copy link

@cszo cszo commented May 12, 2020

我怎么感觉这个改了之后子菜单展现的时候 有明显的延迟 你们感觉到了吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants