Skip to content

improvement: Fix types in form item#22962

Merged
zombieJ merged 2 commits intoant-design:masterfrom
fa93hws:fa93hws/fix-types-formitem
Apr 13, 2020
Merged

improvement: Fix types in form item#22962
zombieJ merged 2 commits intoant-design:masterfrom
fa93hws:fa93hws/fix-types-formitem

Conversation

@fa93hws
Copy link
Copy Markdown
Contributor

@fa93hws fa93hws commented Apr 6, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

fa93hws
fa93hws commented Apr 6, 2020
View reviewed changes
components/form/FormItem.tsx Outdated
Copy link
Copy Markdown
Contributor Author

@fa93hws fa93hws Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

children has already been omitted at https://github.com/ant-design/ant-design/pull/22962/files#diff-94b7635a3702d37a73e4971da7dda90bR21

@fa93hws fa93hws changed the title Fix types in form item type: Fix types in form item Apr 6, 2020
@fa93hws fa93hws changed the title type: Fix types in form item type:Fix types in form item Apr 6, 2020
@ant-design-bot
Copy link
Copy Markdown
Contributor

ant-design-bot commented Apr 6, 2020 •
edited
Loading

@fa93hws fa93hws changed the title type:Fix types in form item type: Fix types in form item Apr 6, 2020
@fa93hws fa93hws changed the title type: Fix types in form item improvement: Fix types in form item Apr 6, 2020
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 6, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71b10fe:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2020 •
edited
Loading

Codecov Report

Merging #22962 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22962      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         365      365              
  Lines        7285     7284       -1     
  Branches     1998     1988      -10     
==========================================
- Hits         7165     7164       -1     
  Misses        120      120
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.13% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653724b...71b10fe. Read the comment docs.

@afc163 afc163 requested a review from zombieJ April 6, 2020 13:48
zombieJ
zombieJ reviewed Apr 9, 2020
View reviewed changes
components/form/FormItem.tsx Outdated
Copy link
Copy Markdown
Member

@zombieJ zombieJ Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create a fragment to wrap this?

Copy link
Copy Markdown
Member

@afc163 afc163 Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fa93hws ping

Copy link
Copy Markdown
Contributor Author

@fa93hws fa93hws Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be as JSX.Element to pass the type check if the fragment is not preferred.

@fa93hws fa93hws force-pushed the fa93hws/fix-types-formitem branch from d243f49 to 71b10fe Compare April 13, 2020 04:58
@zombieJ zombieJ merged commit 436d4b1 into ant-design:master Apr 13, 2020
xrkffgg pushed a commit that referenced this pull request Apr 16, 2020
@fa93hws @xrkffgg
improvement: Fix types in form item (#22962)
a24f3bd 
* Fix types in form item

* use jsx.element
@chenshuai2144 chenshuai2144 mentioned this pull request Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afc163 afc163 afc163 left review comments

@zombieJ zombieJ zombieJ left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fa93hws @ant-design-bot @afc163 @zombieJ