improvement: Fix types in form item #22962
Conversation
| export interface FormItemProps | ||
| extends FormItemLabelProps, | ||
| FormItemInputProps, | ||
| Omit<RcFieldProps, 'children'> { |
There was a problem hiding this comment.
children has already been omitted at https://github.com/ant-design/ant-design/pull/22962/files#diff-94b7635a3702d37a73e4971da7dda90bR21
|
|
fa93hws
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 71b10fe:
|
Codecov Report
@@ Coverage Diff @@
## master #22962 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 365 365
Lines 7285 7284 -1
Branches 1998 1988 -10
==========================================
- Hits 7165 7164 -1
Misses 120 120
Continue to review full report at Codecov.
|
components/form/FormItem.tsx
Outdated
| return children; | ||
| }, | ||
| const MemoInput = React.memo( | ||
| ({ children }: MemoInputProps) => <>{children}</>, |
There was a problem hiding this comment.
Why create a fragment to wrap this?
There was a problem hiding this comment.
It can be as JSX.Element to pass the type check if the fragment is not preferred.
fa93hws
force-pushed
the
fa93hws/fix-types-formitem
branch
from
d243f49
to
71b10fe
Compare
* Fix types in form item * use jsx.element
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge