Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): fix submenu style in dark mode #22981

merged 1 commit into from
Apr 7, 2020

fix(menu): fix submenu style in dark mode #22981

merged 1 commit into from
Apr 7, 2020


Copy link

@AshoneA AshoneA commented Apr 7, 2020

fix #22949

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22949

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu submenu background in dark theme.
🇨🇳 Chinese 修复 Menu 子菜单在暗黑模式下背景为白色的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

ant-design-bot commented Apr 7, 2020

Copy link

codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb1ea68:

Sandbox Source
antd reproduction template Configuration

Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #22981 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22981   +/-   ##
  Coverage   98.31%   98.31%           
  Files         364      364           
  Lines        7260     7260           
  Branches     1992     1944   -48     
  Hits         7138     7138           
  Misses        122      122           
Impacted Files Coverage Δ
components/menu/SubMenu.tsx 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7571372...cb1ea68. Read the comment docs.

@AshoneA AshoneA requested a review from afc163 April 7, 2020 04:54
Copy link

afc163 commented Apr 7, 2020



Copy link
Contributor Author

AshoneA commented Apr 7, 2020



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Dark mode vertical menu submenu items have incorrect color styles
3 participants