Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): fix submenu style in dark mode #22981

Merged
merged 1 commit into from Apr 7, 2020
Merged

fix(menu): fix submenu style in dark mode #22981

merged 1 commit into from Apr 7, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Apr 7, 2020

fix #22949

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22949

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu submenu background in dark theme.
🇨🇳 Chinese 修复 Menu 子菜单在暗黑模式下背景为白色的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 7, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb1ea68:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 7, 2020

Codecov Report

Merging #22981 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22981   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         364      364           
  Lines        7260     7260           
  Branches     1992     1944   -48     
=======================================
  Hits         7138     7138           
  Misses        122      122           
Impacted Files Coverage Δ
components/menu/SubMenu.tsx 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7571372...cb1ea68. Read the comment docs.

@AshoneA AshoneA requested a review from afc163 Apr 7, 2020
@afc163
Copy link
Member

@afc163 afc163 commented Apr 7, 2020

image

确认一下都勾掉。

@AshoneA
Copy link
Contributor Author

@AshoneA AshoneA commented Apr 7, 2020

确认一下都勾掉。

已勾。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants