Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Form.Item support initialValue & getValueProps #22993

Merged
merged 3 commits into from Apr 7, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #21816
resolve #22896
resolve #19727

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form.Item support initialValue and getValueProps props.
🇨🇳 Chinese Form.Item 支持 initialValue 和 getValueProps 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/index.en-US.md
View rendered components/form/index.zh-CN.md

| validateStatus | 校验状态,如不设置,则会根据校验规则自动生成,可选:'success' 'warning' 'error' 'validating' | string | - | |
| validateTrigger | 设置字段校验的时机 | string \| string[] | onChange | |
| valuePropName | 子节点的值的属性,如 Switch 的是 'checked'。该属性为 `getValueProps` 的封装,自定义 `getValueProps` 后会失效 | string | 'value' | |
| wrapperCol | 需要为输入控件设置布局样式时,使用该属性,用法同 `labelCol`。你可以通过 Form 的 `wrapperCol` 进行统一设置。当和 Form 同时设置时,以 Item 为准。 | [object](/components/grid/#Col) | - | |
Copy link
Member

@afc163 afc163 Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这个月会有很多冲突。

Copy link
Member

@afc163 afc163 Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

月底前来加版本吧,或者给 master 先加上一列再 rebase 进来。

Copy link
Member Author

@zombieJ zombieJ Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member Author

@zombieJ zombieJ Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 7, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca762e0:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 7, 2020

Codecov Report

Merging #22993 into feature will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #22993   +/-   ##
========================================
  Coverage    98.36%   98.36%           
========================================
  Files          364      364           
  Lines         7264     7264           
  Branches      1982     1992   +10     
========================================
  Hits          7145     7145           
  Misses         119      119           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77dd5af...ca762e0. Read the comment docs.

afc163
afc163 approved these changes Apr 7, 2020
@zombieJ zombieJ merged commit 77d4569 into feature Apr 7, 2020
29 of 30 checks passed
@zombieJ zombieJ deleted the field-enhancement branch Apr 7, 2020
@crazyair
Copy link
Member

@crazyair crazyair commented May 9, 2020

image

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 9, 2020

@crazyair 没发布修复。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants