Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long submenu title display #23028

Merged
merged 2 commits into from Apr 8, 2020

Conversation

wwyx778
Copy link
Contributor

@wwyx778 wwyx778 commented Apr 8, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22609

💡 Background and solution

Long Submenu Title Being Overlayed By Arrow Icon
Add style : padding-right

📝 Changelog

Language Changelog
🇺🇸 English Fix long Submenu title being overlayed by arrow icon
🇨🇳 Chinese 修复SubMenu标题过长而导致被箭头图标部分覆盖的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 8, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f22693:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #23028 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23028   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         364      364           
  Lines        7264     7264           
  Branches     1945     1945           
=======================================
  Hits         7145     7145           
  Misses        119      119           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c72b34...7f22693. Read the comment docs.

Copy link
Member

@xrkffgg xrkffgg left a comment

RTL 的 也帮忙加一下吧

@xrkffgg
Copy link
Member

xrkffgg commented Apr 8, 2020

changelog 写一下, self check 勾一下~

@wwyx778
Copy link
Contributor Author

wwyx778 commented Apr 8, 2020

changelog 写一下, self check 勾一下~

done. 这个CI总是其他的组件跑不通过是为啥?

@xrkffgg
Copy link
Member

xrkffgg commented Apr 8, 2020

rebase 下 master , push 的时候 记得加 --force 就行

不过也没事

xrkffgg
xrkffgg approved these changes Apr 8, 2020
@xrkffgg xrkffgg merged commit de38c68 into ant-design:master Apr 8, 2020
16 of 19 checks passed
@wwyx778 wwyx778 deleted the fix-submenu-issue-22609 branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants