Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): array support for position in types #23048

Merged
merged 1 commit into from Apr 8, 2020
Merged

fix(pagination): array support for position in types #23048

merged 1 commit into from Apr 8, 2020

Conversation

Arttse
Copy link
Contributor

@Arttse Arttse commented Apr 8, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

Fix TypeScript error in pagination, when using array in position, like

['topRight', 'bottomRight']

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 8, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27e73cf:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 8, 2020

Codecov Report

Merging #23048 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23048   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         364      364           
  Lines        7264     7265    +1     
  Branches     1992     1982   -10     
=======================================
+ Hits         7145     7146    +1     
  Misses        119      119           
Impacted Files Coverage 螖
components/pagination/Pagination.tsx 100.00% <酶> (酶)
components/table/Table.tsx 99.18% <酶> (-0.02%) 猬囷笍
components/form/FormItemInput.tsx 94.11% <100.00%> (+0.56%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 70eaea6...27e73cf. Read the comment docs.

@afc163 afc163 merged commit 0a91df2 into ant-design:master Apr 8, 2020
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants