Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add warning for async #23118

merged 1 commit into from Apr 10, 2020

chore: Add warning for async #23118

merged 1 commit into from Apr 10, 2020


Copy link

@zombieJ zombieJ commented Apr 10, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #22140

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Table add warning info when async mode dataSource length not match with pageSize.
🇨🇳 Chinese Table 在异步数据下 dataSource长度与 pageSize 不匹配时,添加警告信息。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

Copy link

ant-design-bot commented Apr 10, 2020

Copy link

codesandbox-ci bot commented Apr 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a5af72:

Sandbox Source
antd reproduction template Configuration

Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #23118 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23118   +/-   ##
  Coverage   98.36%   98.36%           
  Files         364      364           
  Lines        7265     7267    +2     
  Branches     1993     1944   -49     
+ Hits         7146     7148    +2     
  Misses        119      119           
Impacted Files Coverage Δ
components/table/Table.tsx 99.20% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3df9ec...0a5af72. Read the comment docs.

@zombieJ zombieJ merged commit d968fce into master Apr 10, 2020
32 checks passed
@zombieJ zombieJ deleted the table-async branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

2 participants