Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify table size.less to accomodate size prop for footer padding #23140

Merged
merged 1 commit into from Apr 11, 2020

Conversation

someyoungideas
Copy link
Contributor

@someyoungideas someyoungideas commented Apr 10, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Table Summary Property Size Styling #23139

馃挕 Background and solution

While using the <Table> element with a summary property I realized that the size property styling was not applied to the tfoot element. This fix is to include the tfoot > tr > th and tfoot > tr > td in the styles for tables that use the size property.

image

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English x
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 10, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c383d75:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 10, 2020

Codecov Report

Merging #23140 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23140   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         365      365           
  Lines        7285     7285           
  Branches     1998     1998           
=======================================
  Hits         7165     7165           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bfd5d7c...c383d75. Read the comment docs.

@afc163 afc163 merged commit ca61664 into ant-design:master Apr 11, 2020
21 checks passed
@afc163 afc163 mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants