Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pagination missing showTitle #23144

merged 2 commits into from Apr 11, 2020

fix: Pagination missing showTitle #23144

merged 2 commits into from Apr 11, 2020


Copy link

@donaldnevermore donaldnevermore commented Apr 11, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link


馃挕 Background and solution

The property showTitle in Pagination is stated in the English docs but not in the Chinese docs.
And it's also missing in the PaginationProps.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/pagination/

Copy link

@ant-design-bot ant-design-bot commented Apr 11, 2020

Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68a4002:

Sandbox Source
antd reproduction template Configuration

Copy link

@codecov codecov bot commented Apr 11, 2020

Codecov Report

Merging #23144 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23144   +/-   ##
  Coverage   98.35%   98.35%           
  Files         365      365           
  Lines        7285     7285           
  Branches     1998     1951   -47     
  Hits         7165     7165           
  Misses        120      120           
Impacted Files Coverage 螖
components/pagination/Pagination.tsx 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 50d9086...68a4002. Read the comment docs.

components/pagination/ Outdated Show resolved Hide resolved
Co-Authored-By: 鍋忓彸 <>
@afc163 afc163 merged commit f93f861 into ant-design:master Apr 11, 2020
9 of 15 checks passed
@donaldnevermore donaldnevermore changed the title fix: Pagination missing showTitle (#23134) fix: Pagination missing showTitle Apr 11, 2020
@afc163 afc163 mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants