Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tabs_animation_bug #23151

Merged
merged 3 commits into from Apr 13, 2020
Merged

Conversation

imhxc
Copy link
Contributor

@imhxc imhxc commented Apr 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23050

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the issue that Tabs component cannot be displayed in Safair browser.
🇨🇳 Chinese 修复 Tabs 开启动画的情况下,在 Safair 浏览器下的无法显示的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 12, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9fe57ea:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented Apr 12, 2020

image

@afc163
Copy link
Member

afc163 commented Apr 12, 2020

Rebase master to fix ci.

@imhxc
Copy link
Contributor Author

imhxc commented Apr 12, 2020

@afc163
I modified the place you just mentioned, but still some checks were not successful.
I don't know if these errors are related to me, I hope to get help.

@afc163
Copy link
Member

afc163 commented Apr 12, 2020

Rebase master to fix ci.

> .@{tab-prefix-cls}-tabpane {
flex-shrink: 0;
width: 100%;
-webkit-backface-visibility: hidden;
Copy link
Contributor

@yoyo837 yoyo837 Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是需要再补个标准属性?backface-visibility

Copy link
Member

@afc163 afc163 Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要了,特别给 safari 老版本做兼容用的。

@afc163 afc163 merged commit 653724b into ant-design:master Apr 13, 2020
18 checks passed
xrkffgg pushed a commit that referenced this issue Apr 13, 2020
* fix: tabs_animation_bug

* fix: fix lint error

Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>
xrkffgg pushed a commit that referenced this issue Apr 16, 2020
* fix: tabs_animation_bug

* fix: fix lint error

Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>
@nick-ChenZe
Copy link
Contributor

nick-ChenZe commented May 14, 2020

@afc163 this bug still in 3.26.16, this pr should cherry-pick to 3.x.
thanks

yoyo837 pushed a commit that referenced this issue May 14, 2020
* fix: tabs_animation_bug

* fix: fix lint error

Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>
afc163 pushed a commit that referenced this issue May 15, 2020
* fix: tabs_animation_bug

* fix: fix lint error

Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>

Co-authored-by: HouXiancheng <505421473@qq.com>
Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this issue Aug 23, 2021
* fix: tabs_animation_bug

* fix: fix lint error

Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>

Co-authored-by: HouXiancheng <505421473@qq.com>
Co-authored-by: 侯先诚 <houxiancheng@houxianchengdeMacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants