Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safari12 fixed column #23161

Merged
merged 2 commits into from Apr 12, 2020
Merged

fix: Safari12 fixed column #23161

merged 2 commits into from Apr 12, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22377

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table fixed column can not ping in Safari 12.
🇨🇳 Chinese 修复 Table 固定列在 Safari 12 中不能固定的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 12, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c588e2:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 23c6a74:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 12, 2020

Codecov Report

Merging #23161 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23161   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         365      365           
  Lines        7285     7285           
  Branches     1998     1988   -10     
=======================================
  Hits         7165     7165           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb6c4c...23c6a74. Read the comment docs.

@imhxc
Copy link
Contributor

@imhxc imhxc commented Apr 12, 2020

Should add !important to override the inline style.

ztplz
ztplz approved these changes Apr 12, 2020
@zombieJ zombieJ merged commit 12ce6ab into master Apr 12, 2020
31 checks passed
@zombieJ zombieJ deleted the safari-12 branch Apr 12, 2020
xrkffgg pushed a commit that referenced this issue Apr 13, 2020
* fix: Safari12 fixed column

* fix lint
xrkffgg pushed a commit that referenced this issue Apr 16, 2020
* fix: Safari12 fixed column

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants