Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Form default locale #23165

Merged
merged 6 commits into from
Apr 18, 2020
Merged

improvement: Form default locale #23165

merged 6 commits into from
Apr 18, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 12, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23148

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form add zh_CN locale
🇨🇳 Chinese Form增加中文文案

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hengkx hengkx changed the title improve: Form default locale improvement: Form default locale Apr 12, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 12, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 310eb45:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #23165 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23165      +/-   ##
==========================================
+ Coverage   98.35%   98.36%   +0.01%     
==========================================
  Files         365      365              
  Lines        7285     7291       +6     
  Branches     1998     1953      -45     
==========================================
+ Hits         7165     7172       +7     
+ Misses        120      119       -1     
Impacted Files Coverage Δ
components/locale-provider/index.tsx 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (+4.16%) ⬆️
components/locale/zh_CN.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb6c4c...310eb45. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Apr 14, 2020

加个 test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form的默认文案是英文?
5 participants