Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Form default locale #23165

Merged
merged 6 commits into from Apr 18, 2020
Merged

improvement: Form default locale #23165

merged 6 commits into from Apr 18, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 12, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

close #23148

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Form add zh_CN locale
馃嚚馃嚦 Chinese Form澧炲姞涓枃鏂囨

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hengkx hengkx changed the title improve: Form default locale improvement: Form default locale Apr 12, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 12, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 310eb45:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 12, 2020

Codecov Report

Merging #23165 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23165      +/-   ##
==========================================
+ Coverage   98.35%   98.36%   +0.01%     
==========================================
  Files         365      365              
  Lines        7285     7291       +6     
  Branches     1998     1953      -45     
==========================================
+ Hits         7165     7172       +7     
+ Misses        120      119       -1     
Impacted Files Coverage 螖
components/locale-provider/index.tsx 100.00% <酶> (酶)
components/config-provider/index.tsx 100.00% <100.00%> (+4.16%) 猬嗭笍
components/locale/zh_CN.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6bb6c4c...310eb45. Read the comment docs.

components/locale/zh_CN.tsx Outdated Show resolved Hide resolved
components/locale/zh_CN.tsx Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 14, 2020

鍔犱釜 test case

@hengkx hengkx requested a review from zombieJ Apr 17, 2020
@afc163 afc163 merged commit 50416b3 into master Apr 18, 2020
31 checks passed
@afc163 afc163 deleted the improve/form branch Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants