Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notification rtl config #23185

Merged
merged 2 commits into from Apr 13, 2020
Merged

feat: add notification rtl config #23185

merged 2 commits into from Apr 13, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

类似于 Message : #22513
通过

notification.config({
  rtl: true,
});

开启 RTL

📝 Changelog

Language Changelog
🇺🇸 English Add Notification RTL config
🇨🇳 Chinese 增加 Notification RTL 设置

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/notification/index.en-US.md
View rendered components/notification/index.zh-CN.md

@xrkffgg xrkffgg changed the title feat: add notification rtl config [WIP] feat: add notification rtl config Apr 13, 2020
@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Apr 13, 2020

我加个 test

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 13, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b1dc5c9:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 13, 2020

Codecov Report

Merging #23185 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23185   +/-   ##
========================================
  Coverage    98.35%   98.35%           
========================================
  Files          365      365           
  Lines         7285     7289    +4     
  Branches      1951     1999   +48     
========================================
+ Hits          7165     7169    +4     
  Misses         120      120           
Impacted Files Coverage Δ
components/notification/index.tsx 96.77% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e952a...b1dc5c9. Read the comment docs.

@xrkffgg xrkffgg changed the title [WIP] feat: add notification rtl config feat: add notification rtl config Apr 13, 2020
@xrkffgg xrkffgg requested review from afc163 and zombieJ Apr 13, 2020
afc163
afc163 approved these changes Apr 13, 2020
@afc163 afc163 merged commit fca1367 into feature Apr 13, 2020
31 checks passed
@afc163 afc163 deleted the add-rtl branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants