Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table selection childrenColumnName not work #23205

Merged
merged 3 commits into from Apr 13, 2020
Merged

fix: Table selection childrenColumnName not work #23205

merged 3 commits into from Apr 13, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23197

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table rowSelection params issue when childrenColumnName configured.
🇨🇳 Chinese 修复 Table rowSelection 在设置 childrenColumnName时事件参数不正确的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 13, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit faca2bb:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 13, 2020

Codecov Report

Merging #23205 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23205   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         365      365           
  Lines        7284     7284           
  Branches     1951     1998   +47     
=======================================
  Hits         7164     7164           
  Misses        120      120           
Impacted Files Coverage Δ
components/table/Table.tsx 99.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436d4b1...faca2bb. Read the comment docs.

@zombieJ zombieJ merged commit 8c11676 into master Apr 13, 2020
32 checks passed
@zombieJ zombieJ deleted the selection branch Apr 13, 2020
xrkffgg pushed a commit that referenced this issue Apr 16, 2020
* fix childrenPropName

* test case

* update test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants