fix: Fix popupClassName prop in timepicker #23214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f275793:
|
Codecov Report
@@ Coverage Diff @@
## master #23214 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 365 365
Lines 7284 7284
Branches 1999 1988 -11
=======================================
Hits 7164 7164
Misses 120 120
Continue to review full report at Codecov.
|
yoyo837
changed the title
yoyo837
reviewed
Apr 14, 2020
yoyo837
reviewed
Apr 14, 2020
yoyo837
reviewed
Apr 14, 2020
yoyo837
reviewed
Apr 14, 2020
yoyo837
reviewed
Apr 14, 2020
|
The translated content of the demo doc, please team members to review. |
afc163
reviewed
Apr 14, 2020
|
中文用的日文噢。 |
|
没关系，我先改成 debug 模式了默认不展示。 |
xrkffgg
pushed a commit
that referenced
this pull request
Apr 16, 2020
* fix(time-picker): combine dropdownClassName and popupClassName prop * test(time-picker): add test for popupClassName and dropdownClassName prop * chore(time-picker): add demo for popupClassName prop * test(time-picker): remove rc-picker dependency * doc(time-picker): change default prop of popupClassName to undefined * fix(time-picker): remove the use of dropdownClassName * Apply suggestions from code review Co-authored-by: 偏右 <afc163@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
closes #22807
💡 Background and solution
In 3.x
rc-time-pickeris being used but in 4.x it has been replaced byrc-picker.rc-time-pickerhas a prop calledpopupClassNamebut this prop is not available inrc-pickerPass
popupClassNameprop torc-pickerthroughdropdownClassNameprop📝 Changelog
rc-pickertime-picker自4.0-alpha-0以来popupClassName的支持☑️ Self Check before Merge