Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix popupClassName prop in timepicker #23214

Merged

Conversation

tanmoyopenroot
Copy link
Contributor

@tanmoyopenroot tanmoyopenroot commented Apr 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

closes #22807

💡 Background and solution

In 3.x rc-time-picker is being used but in 4.x it has been replaced by rc-picker.
rc-time-picker has a prop called popupClassName but this prop is not available in rc-picker

PasspopupClassName prop to rc-picker through dropdownClassName prop

📝 Changelog

Language Changelog
🇺🇸 English pass popupClassName prop to rc-picker
🇨🇳 Chinese 修复time-picker4.0-alpha-0以来popupClassName的支持

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 14, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f275793:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Apr 14, 2020

Codecov Report

Merging #23214 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23214   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         365      365           
  Lines        7284     7284           
  Branches     1999     1988   -11     
=======================================
  Hits         7164     7164           
  Misses        120      120           
Impacted Files Coverage Δ
components/time-picker/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c11676...f275793. Read the comment docs.

@yoyo837 yoyo837 changed the title Fix popupClassName prop in timepicker fix: Fix popupClassName prop in timepicker Apr 14, 2020
components/time-picker/index.tsx Outdated Show resolved Hide resolved
components/time-picker/index.tsx Outdated Show resolved Hide resolved
components/time-picker/index.tsx Outdated Show resolved Hide resolved
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 14, 2020

The translated content of the demo doc, please team members to review.

@afc163 afc163 merged commit e3d2754 into ant-design:master Apr 14, 2020
5 of 7 checks passed
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 14, 2020

中文用的日文噢。

@afc163
Copy link
Member

@afc163 afc163 commented Apr 14, 2020

没关系,我先改成 debug 模式了默认不展示。

xrkffgg pushed a commit that referenced this issue Apr 16, 2020
* fix(time-picker): combine dropdownClassName and popupClassName prop

* test(time-picker): add test for popupClassName and dropdownClassName prop

* chore(time-picker): add demo for popupClassName prop

* test(time-picker): remove rc-picker dependency

* doc(time-picker): change default prop of popupClassName to undefined

* fix(time-picker): remove the use of dropdownClassName

* Apply suggestions from code review

Co-authored-by: 偏右 <afc163@gmail.com>
@tanmoyopenroot tanmoyopenroot deleted the 22807-fix-popupClassName-in-timepicker branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants