Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tree-select render blank in compact mode #23231

Merged
merged 1 commit into from Apr 14, 2020
Merged

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Apr 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23223

💡 Background and solution

默认值按紧凑模式下的高度来算,会多渲染几条,不过感觉问题不大。

📝 Changelog

Language Changelog
🇺🇸 English fix TreeSelect render blank in compact mode.
🇨🇳 Chinese 修复紧凑模式下树选择出现空白

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@AshoneA AshoneA requested a review from zombieJ as a code owner Apr 14, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 14, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7e57679:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #23231 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23231   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         364      364           
  Lines        7284     7284           
  Branches     1988     1988           
=======================================
  Hits         7164     7164           
  Misses        120      120           
Impacted Files Coverage Δ
components/tree-select/index.tsx 97.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6733b...7e57679. Read the comment docs.

@zombieJ zombieJ merged commit efd2510 into master Apr 14, 2020
32 checks passed
@zombieJ zombieJ deleted the fix/tree-select-compact branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants