Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix select rtl #23235

Merged
merged 2 commits into from Apr 14, 2020
Merged

fix: fix select rtl #23235

merged 2 commits into from Apr 14, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 14, 2020 •
edited

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23207

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English none
🇨🇳 Chinese none

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 14, 2020 •
edited

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 14, 2020

如果用户开启RTL, select再支持一个ltr属性如何？

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 14, 2020 •
edited

可能用户也会遇到再RTL下不开启RTL的情况。就好比他们自己App的版本Switcher，类似antd站点的这个。

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 14, 2020

dropdownStyle 可以定制

再加个属性也可以，就怕这 2 个 rtl 对用户来说，有点绕

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 14, 2020

dropdownStyle 可以定制

再加个属性也可以，就怕这 2 个 rtl 对用户来说，有点绕

总比不能做到，非得自己覆盖css好。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 14, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ff8fbc:

Sandbox Source
antd reproduction template Configuration

@xrkffgg @yoyo837
fix lint
9ff8fbc 
Co-Authored-By: Amumu <yoyo837@hotmail.com>
@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 14, 2020

如果用户开启RTL, select再支持一个ltr属性如何？

这个要不要讨论下可行性？

@afc163 @zombieJ 大佬意见呢？

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 14, 2020

如果用户开启RTL, select再支持一个ltr属性如何？

这个要不要讨论下可行性？

@afc163 @zombieJ 大佬意见呢？

我看见你说dropdownStyle 可以定制我又删了评论。😂

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 14, 2020

定制的话，要写一堆，不够简洁

再 增加一个 关于 rtl 的，我怕有些人理解不了意思😂😂😂

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 14, 2020 •
edited

那就先这么着吧。

@codecov
Copy link

codecov bot commented Apr 14, 2020 •
edited

Codecov Report

Merging #23235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23235   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         364      364           
  Lines        7284     7284           
  Branches     1988     1951   -37     
=======================================
  Hits         7164     7164           
  Misses        120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6733b...9ff8fbc. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Apr 14, 2020

先不支持了，太复杂了。

@afc163 afc163 merged commit 1855fef into master Apr 14, 2020
@afc163 afc163 deleted the fix-select-rtl branch April 14, 2020 08:42
xrkffgg added a commit that referenced this pull request Apr 16, 2020
@xrkffgg @yoyo837
fix: fix select rtl (#23235)
e0369fc 
* fix: fix select rtl

* fix lint

Co-Authored-By: Amumu <yoyo837@hotmail.com>

Co-authored-by: Amumu <yoyo837@hotmail.com>
@chenshuai2144 chenshuai2144 mentioned this pull request Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pagination number per page RTL
4 participants
@xrkffgg @ant-design-bot @yoyo837 @afc163