Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input inline allowClear style #23259

Merged
merged 3 commits into from Apr 14, 2020
Merged

fix: Input inline allowClear style #23259

merged 3 commits into from Apr 14, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 14, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #22562

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input inline with allowClear shaking when trigger clear icon.
🇨🇳 Chinese 修复 Input 设置 allowClear 内联展示时,触发清除按钮样式抖动的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 14, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8537e6e:

Sandbox Source
antd reproduction template Configuration

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Apr 14, 2020

还是有这个问题 #22574 (comment)

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 14, 2020

唔,placeholder 的确是没什么好办法。

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Apr 14, 2020

嗯,我也没想到,确实有点棘手

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 14, 2020

那只能搞个假的 placeholder 了。

@codecov
Copy link

@codecov codecov bot commented Apr 14, 2020

Codecov Report

Merging #23259 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23259      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         364      364              
  Lines        7284     7279       -5     
  Branches     1951     1993      +42     
==========================================
- Hits         7164     7159       -5     
  Misses        120      120              
Impacted Files Coverage Δ
components/input/ClearableLabeledInput.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178ccbe...8537e6e. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Apr 14, 2020

input 搞假 placeholder 没必要啊。

Copy link
Member

@shaodahong shaodahong left a comment

先这样吧感觉,placeholder 的优先级不是很高,可以放一放

@shaodahong
Copy link
Member

@shaodahong shaodahong commented Apr 14, 2020

假的 placeholder 也有一些兼容性问题,太拼了

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Apr 14, 2020

👌 那先这样吧,有 issue 再来搞。

@zombieJ zombieJ merged commit 02d7292 into master Apr 14, 2020
31 checks passed
@zombieJ zombieJ deleted the input-clear branch Apr 14, 2020
xrkffgg pushed a commit that referenced this issue Apr 16, 2020
* fix: Input allow clear icon

* update test case

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants