-
-
Notifications
You must be signed in to change notification settings - Fork 50.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Input inline allowClear style #23259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8537e6e:
|
还是有这个问题 #22574 (comment) |
唔,placeholder 的确是没什么好办法。 |
嗯,我也没想到,确实有点棘手 |
那只能搞个假的 |
Codecov Report
@@ Coverage Diff @@
## master #23259 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 364 364
Lines 7284 7279 -5
Branches 1951 1993 +42
==========================================
- Hits 7164 7159 -5
Misses 120 120
Continue to review full report at Codecov.
|
input 搞假 placeholder 没必要啊。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先这样吧感觉,placeholder 的优先级不是很高,可以放一放
假的 placeholder 也有一些兼容性问题,太拼了 |
👌 那先这样吧,有 issue 再来搞。 |
* fix: Input allow clear icon * update test case * update snapshot
🤔 This is a ...
🔗 Related issue link
fix #22562
💡 Background and solution
📝 Changelog
allowClear
shaking when trigger clear icon.allowClear
内联展示时,触发清除按钮样式抖动的问题。☑️ Self Check before Merge