Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select custom suffixIcon should be accessible #23274

Merged
merged 1 commit into from Apr 15, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 15, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23263

💡 Background and solution

When custom suffixIcon of Select, it should be expected to be handable.

📝 Changelog

Language Changelog
🇺🇸 English Fix Select custom suffixIcon cannot be access.
🇨🇳 Chinese 修复 Select 自定义 suffixIcon 无法交互的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 changed the title fix Select custom suffixIcon could be operated fix Select custom suffixIcon could be access Apr 15, 2020
@afc163 afc163 changed the title fix Select custom suffixIcon could be access fix: Select custom suffixIcon should be accessible Apr 15, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 15, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24c4614:

Sandbox Source
antd reproduction template Configuration
Tags - Ant Design Demo Issue #23263

@codecov
Copy link

@codecov codecov bot commented Apr 15, 2020

Codecov Report

Merging #23274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23274   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         364      364           
  Lines        7279     7279           
  Branches     1946     1946           
=======================================
  Hits         7159     7159           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a1fe5...24c4614. Read the comment docs.

@luckyxutao
Copy link

@luckyxutao luckyxutao commented Mar 18, 2021

image
需要添加className="ant-select-suffix"才有效果

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants