Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple selector disabled remove icon #23295

Merged
merged 2 commits into from Apr 15, 2020
Merged

fix: multiple selector disabled remove icon #23295

merged 2 commits into from Apr 15, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 15, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23290

ref https://github.com/react-component/select/blob/bc567e18269ece6123d4cc27fbfad8476c3b25a6/tests/shared/removeSelectedTest.tsx#L29

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix multiple Select show remove icon when disabled.
🇨🇳 Chinese 修复 Select 多选时设置 disabled 选项仍然会展示移除按钮的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 15, 2020

afc163
afc163 approved these changes Apr 15, 2020
afc163
afc163 approved these changes Apr 15, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8858ea2:

Sandbox Source
antd reproduction template Configuration

@zombieJ zombieJ merged commit f7d1d41 into master Apr 15, 2020
26 of 29 checks passed
@zombieJ zombieJ deleted the fix-multiple-selector branch Apr 15, 2020
xrkffgg pushed a commit that referenced this issue Apr 16, 2020
* fix: Select remove icon

* revert demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants