Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Space support align #23306

Merged
merged 7 commits into from Apr 16, 2020
Merged

feat: Space support align #23306

merged 7 commits into from Apr 16, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 16, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #23286

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Space support align prop.
🇨🇳 Chinese Space 支持 align 属性。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/space/demo/align.md
View rendered components/space/demo/customize.md

@zombieJ zombieJ requested review from shaodahong and afc163 Apr 16, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 16, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46a2756:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Apr 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ec4663:

Sandbox Source
antd reproduction template Configuration

components/space/index.en-US.md Outdated Show resolved Hide resolved
components/space/demo/align.md Outdated Show resolved Hide resolved
zombieJ and others added 3 commits Apr 16, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 16, 2020

Codecov Report

Merging #23306 into feature will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #23306   +/-   ##
========================================
  Coverage    98.35%   98.35%           
========================================
  Files          365      365           
  Lines         7290     7291    +1     
  Branches      2000     2002    +2     
========================================
+ Hits          7170     7171    +1     
  Misses         120      120           
Impacted Files Coverage Δ
components/space/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87da7bf...c46a45f. Read the comment docs.

Copy link
Member

@shaodahong shaodahong left a comment

LGTM

afc163
afc163 approved these changes Apr 16, 2020
@zombieJ zombieJ merged commit 7e9fe27 into feature Apr 16, 2020
30 checks passed
@zombieJ zombieJ deleted the space-align branch Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants