feat: add rate direction #23321
Merged
feat: add rate direction #23321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be3309f:
|
|
测试用例挂了。 |
Codecov Report
@@ Coverage Diff @@
## feature #23321 +/- ##
===========================================
- Coverage 98.38% 98.38% -0.01%
===========================================
Files 364 364
Lines 7326 7325 -1
Branches 1960 1960
===========================================
- Hits 7208 7207 -1
Misses 118 118
Continue to review full report at Codecov.
|
|
@afc163 这个报错是因为 lock 的原因吗？ |
afc163
reviewed
Apr 20, 2020
components/rate/index.tsx
Outdated
| const rateClassNames = classNames(className, { | ||
| [`${ratePrefixCls}-rtl`]: direction === 'rtl', | ||
| }); | ||
| const rateClassNames = classNames(className); |
afc163
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
close #22296
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge