Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rate direction #23321

Merged
merged 3 commits into from Apr 20, 2020
Merged

feat: add rate direction #23321

merged 3 commits into from Apr 20, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Apr 16, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #22296

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add Rate direction
🇨🇳 Chinese 新增 Rate 的 direction 支持优化

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg xrkffgg requested a review from afc163 Apr 16, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 16, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be3309f:

Sandbox Source
antd reproduction template Configuration

@afc163
Copy link
Member

afc163 commented Apr 18, 2020

测试用例挂了。

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #23321 into feature will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #23321      +/-   ##
===========================================
- Coverage    98.38%   98.38%   -0.01%     
===========================================
  Files          364      364              
  Lines         7326     7325       -1     
  Branches      1960     1960              
===========================================
- Hits          7208     7207       -1     
  Misses         118      118              
Impacted Files Coverage Δ
components/rate/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabec48...be3309f. Read the comment docs.

@xrkffgg
Copy link
Member Author

xrkffgg commented Apr 20, 2020

@afc163 这个报错是因为 lock 的原因吗?

const rateClassNames = classNames(className, {
[`${ratePrefixCls}-rtl`]: direction === 'rtl',
});
const rateClassNames = classNames(className);
Copy link
Member

@afc163 afc163 Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个变量没意义了,直接透传就行了。

@xrkffgg xrkffgg requested a review from afc163 Apr 20, 2020
afc163
afc163 approved these changes Apr 20, 2020
@afc163 afc163 merged commit 757c576 into feature Apr 20, 2020
30 checks passed
@afc163 afc163 deleted the feat-rate-rtl branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants