Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Search ConfigProvider size #23331

Merged
merged 4 commits into from Apr 18, 2020
Merged

fix: Input.Search ConfigProvider size #23331

merged 4 commits into from Apr 18, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Apr 16, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23328

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: Input.Search ConfigProvider size
🇨🇳 Chinese 修复Input.Search全局设置size不生效问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 16, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a3d530:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #23331 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23331   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         364      364           
  Lines        7279     7287    +8     
  Branches     1946     1950    +4     
=======================================
+ Hits         7160     7168    +8     
  Misses        119      119           
Impacted Files Coverage Δ
components/input/Search.tsx 97.53% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5910f...4a3d530. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Apr 17, 2020

来个用例吧。

@hengkx hengkx requested review from yoyo837 and afc163 Apr 17, 2020
{renderComponent({})}
</ConfigProvider>,
),
).toMatchSnapshot();
Copy link
Contributor

@yoyo837 yoyo837 Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断一下class 加载对不对

{renderComponent({})}
</ConfigProvider>,
),
).toMatchSnapshot();
Copy link
Contributor

@yoyo837 yoyo837 Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断一下class 加载对不对

Copy link
Contributor

@yoyo837 yoyo837 Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意所有的组件都使用这个抽取,不止一个组件

Copy link
Member

@afc163 afc163 Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对应的 Snapshot 文件在哪里

Copy link
Member Author

@hengkx hengkx Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/config-provider/tests/snapshots/components.test.js.snap
文件是在这个里面
@yoyo837 生成snapshots了 不就是可以判断了吗?
因为之前单元测试没有覆盖到全局默认配置size 所以我给所有组件全局配置都加了size的snapshots

@hengkx hengkx requested a review from yoyo837 Apr 18, 2020
@zombieJ
Copy link
Member

zombieJ commented Apr 18, 2020

@afc163 afc163 merged commit 6e1ffb9 into master Apr 18, 2020
31 checks passed
@afc163 afc163 deleted the fix/input-size branch Apr 18, 2020
chenshuai2144 added a commit to chenshuai2144/ant-design that referenced this issue Apr 18, 2020
chenshuai2144 added a commit that referenced this issue Apr 18, 2020
* doc: add 4.1.4 changelog

* fix error version

* sort log

* groud log

* add #23331

* fix review doc

* fix review doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants